Skip to content

Archive testing #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

chen-lia
Copy link

@chen-lia chen-lia commented Nov 6, 2020

Remember, this is a shared responsibility between the developer and reviewers, and all parties take ownership of the code when it is merged.

What is the purpose and intent of this pull request?

What will be impacted and what flows and edge cases have you tested?

Developer & Reviewer Checklist

Remember to provide good feedback!

  • Ask, don’t tell.
  • Explain your reasons why code should be changed.
  • Offer ways to simplify or improve code.
  • Be humble, and avoid hyperbole (“NEVER do…”)
  • If it's too complex, feel free to get face-to-face time with the developer (or a design review)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants